mfd: rt5033: Fix errorneous defines
authorMichael Srba <Michael.Srba@seznam.cz>
Tue, 10 Nov 2020 13:00:47 +0000 (14:00 +0100)
committerLee Jones <lee.jones@linaro.org>
Thu, 19 Nov 2020 08:34:23 +0000 (08:34 +0000)
Fix regulators on rt5033 by converting some values to bitmasks which were
errorneously not defined as such in the header file.

Cc: Beomho Seo <beomho.seo@samsung.com>
Fixes: 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.")
Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
include/linux/mfd/rt5033-private.h

index f812105c538c8189880eec4ce76820723550cfb9..2d1895c3efbf2e17388fac8d2d3453cf24bb248b 100644 (file)
@@ -91,14 +91,14 @@ enum rt5033_reg {
 #define RT5033_RT_HZ_MASK              0x01
 
 /* RT5033 control register */
-#define RT5033_CTRL_FCCM_BUCK_MASK             0x00
-#define RT5033_CTRL_BUCKOMS_MASK               0x01
-#define RT5033_CTRL_LDOOMS_MASK                        0x02
-#define RT5033_CTRL_SLDOOMS_MASK               0x03
-#define RT5033_CTRL_EN_BUCK_MASK               0x04
-#define RT5033_CTRL_EN_LDO_MASK                        0x05
-#define RT5033_CTRL_EN_SAFE_LDO_MASK           0x06
-#define RT5033_CTRL_LDO_SLEEP_MASK             0x07
+#define RT5033_CTRL_FCCM_BUCK_MASK             BIT(0)
+#define RT5033_CTRL_BUCKOMS_MASK               BIT(1)
+#define RT5033_CTRL_LDOOMS_MASK                        BIT(2)
+#define RT5033_CTRL_SLDOOMS_MASK               BIT(3)
+#define RT5033_CTRL_EN_BUCK_MASK               BIT(4)
+#define RT5033_CTRL_EN_LDO_MASK                        BIT(5)
+#define RT5033_CTRL_EN_SAFE_LDO_MASK           BIT(6)
+#define RT5033_CTRL_LDO_SLEEP_MASK             BIT(7)
 
 /* RT5033 BUCK control register */
 #define RT5033_BUCK_CTRL_MASK                  0x1f
@@ -247,11 +247,11 @@ enum rt5033_fuel_reg {
 #define RT5033_FUEL_BAT_PRESENT                0x02
 
 /* RT5033 PMIC interrupts */
-#define RT5033_PMIC_IRQ_BUCKOCP                2
-#define RT5033_PMIC_IRQ_BUCKLV         3
-#define RT5033_PMIC_IRQ_SAFELDOLV      4
-#define RT5033_PMIC_IRQ_LDOLV          5
-#define RT5033_PMIC_IRQ_OT             6
-#define RT5033_PMIC_IRQ_VDDA_UV                7
+#define RT5033_PMIC_IRQ_BUCKOCP                BIT(2)
+#define RT5033_PMIC_IRQ_BUCKLV         BIT(3)
+#define RT5033_PMIC_IRQ_SAFELDOLV      BIT(4)
+#define RT5033_PMIC_IRQ_LDOLV          BIT(5)
+#define RT5033_PMIC_IRQ_OT             BIT(6)
+#define RT5033_PMIC_IRQ_VDDA_UV                BIT(7)
 
 #endif /* __RT5033_PRIVATE_H__ */