Optimize replaceShortcodeTokens

We can of course skip reading the entire byte slice again and again.

This was a slip in the original implementation; functionally the same,
but is slightly faster, esp. for larger data sets with many shortcodes:

```
benchmark                             old ns/op     new ns/op     delta
BenchmarkReplaceShortcodeTokens-4     15505         14753         -4.85%

benchmark                             old allocs     new allocs     delta
BenchmarkReplaceShortcodeTokens-4     1              1              +0.00%

benchmark                             old bytes     new bytes     delta
BenchmarkReplaceShortcodeTokens-4     3072          3072          +0.00%
```

diff --git a/hugolib/shortcode.go b/hugolib/shortcode.go
index 3ceef54efb89b67e0db1a7cfbe2b175bc62a411c..a1e0cc35deacd4403067cfe50ea87c87a6a92a9e 100644 (file)
--- a/hugolib/shortcode.go
+++ b/hugolib/shortcode.go
@@ -506,7 +506,7 @@ func replaceShortcodeTokens(source []byte, prefix string, replacements map[strin
 
                // This and other cool slice tricks: https://github.com/golang/go/wiki/SliceTricks
                source = append(source[:j], append(newVal, source[end:]...)...)
-
+               start = j
                k = bytes.Index(source[start:], pre)
 
        }