soc/tegra: fuse: Use dev_err_probe for probe failures
authorKartik <kkartik@nvidia.com>
Tue, 17 Oct 2023 05:23:16 +0000 (10:53 +0530)
committerThierry Reding <treding@nvidia.com>
Thu, 1 Feb 2024 14:58:05 +0000 (15:58 +0100)
Currently, in tegra_fuse_probe() if clock/reset get fails, then the
driver prints an error if the error is not caused by -EPROBE_DEFER.
This can be improved by using dev_err_probe() instead.

So, return dev_err_probe() if clock/reset get fails.

Signed-off-by: Kartik <kkartik@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/soc/tegra/fuse/fuse-tegra.c

index a2c28f493a75e52a0e620dd5fa35c2636d40d4ae..98805885158e9dae6f7489cb9d56e6d82fcf1201 100644 (file)
@@ -131,13 +131,8 @@ static int tegra_fuse_probe(struct platform_device *pdev)
        fuse->phys = res->start;
 
        fuse->clk = devm_clk_get(&pdev->dev, "fuse");
-       if (IS_ERR(fuse->clk)) {
-               if (PTR_ERR(fuse->clk) != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "failed to get FUSE clock: %ld",
-                               PTR_ERR(fuse->clk));
-
-               return PTR_ERR(fuse->clk);
-       }
+       if (IS_ERR(fuse->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(fuse->clk), "failed to get FUSE clock\n");
 
        platform_set_drvdata(pdev, fuse);
        fuse->dev = &pdev->dev;
@@ -179,12 +174,8 @@ static int tegra_fuse_probe(struct platform_device *pdev)
        }
 
        fuse->rst = devm_reset_control_get_optional(&pdev->dev, "fuse");
-       if (IS_ERR(fuse->rst)) {
-               err = PTR_ERR(fuse->rst);
-               dev_err(&pdev->dev, "failed to get FUSE reset: %pe\n",
-                       fuse->rst);
-               return err;
-       }
+       if (IS_ERR(fuse->rst))
+               return dev_err_probe(&pdev->dev, PTR_ERR(fuse->rst), "failed to get FUSE reset\n");
 
        /*
         * FUSE clock is enabled at a boot time, hence this resume/suspend