]> git.maquefel.me Git - brevno-suite/hugo/commitdiff
tpl/transform: Display Chroma highlighting errors
authorJoe Mooring <joe.mooring@veriphor.com>
Sun, 3 Dec 2023 22:38:49 +0000 (14:38 -0800)
committerBjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
Mon, 4 Dec 2023 10:38:23 +0000 (11:38 +0100)
Closes #9642

tpl/transform/integration_test.go
tpl/transform/transform.go

index 9a68b7ff2c3c9906c413f56e952ff62bfd117f1e..3ba65c715114a3b1cac956487e093eadf425ce1b 100644 (file)
@@ -16,6 +16,7 @@ package transform_test
 import (
        "testing"
 
+       qt "github.com/frankban/quicktest"
        "github.com/gohugoio/hugo/hugolib"
 )
 
@@ -85,3 +86,24 @@ a **b** \v c
        <description>&lt;p&gt;a &lt;strong&gt;b&lt;/strong&gt;  c&lt;/p&gt;</description>
        `)
 }
+
+// Issue #9642
+func TestHighlightError(t *testing.T) {
+       t.Parallel()
+
+       files := `
+-- hugo.toml --
+disableKinds = ['page','rss','section','sitemap','taxonomy','term']
+-- layouts/index.html --
+{{ highlight "a" "b" 0 }}
+  `
+       b := hugolib.NewIntegrationTestBuilder(
+               hugolib.IntegrationTestConfig{
+                       T:           t,
+                       TxtarString: files,
+               },
+       )
+
+       _, err := b.BuildE()
+       b.Assert(err.Error(), qt.Contains, "error calling highlight: invalid Highlight option: 0")
+}
index 178db84e412b1605e8ac9c4bebcbf078db0f28f5..8078bc0ceac3790c24f9698f1792b7aeb8223d54 100644 (file)
@@ -79,7 +79,10 @@ func (ns *Namespace) Highlight(s any, lang string, opts ...any) (template.HTML,
        }
 
        hl := ns.deps.ContentSpec.Converters.GetHighlighter()
-       highlighted, _ := hl.Highlight(ss, lang, optsv)
+       highlighted, err := hl.Highlight(ss, lang, optsv)
+       if err != nil {
+               return "", err
+       }
        return template.HTML(highlighted), nil
 }