selftests: ktap_helpers: Make it POSIX-compliant
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Mon, 15 Apr 2024 15:32:15 +0000 (11:32 -0400)
committerShuah Khan <skhan@linuxfoundation.org>
Mon, 6 May 2024 19:57:20 +0000 (13:57 -0600)
There are a couple uses of bash specific syntax in the script. Change
them to the equivalent POSIX syntax. This doesn't change functionality
and allows non-bash test scripts to make use of these helpers.

Reported-by: Mike Looijmans <mike.looijmans@topic.nl>
Closes: https://lore.kernel.org/all/efae4037-c22a-40be-8ba9-7c1c12ece042@topic.nl/
Fixes: 2dd0b5a8fcc4 ("selftests: ktap_helpers: Add a helper to finish the test")
Fixes: 14571ab1ad21 ("kselftest: Add new test for detecting unprobed Devicetree devices")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/kselftest/ktap_helpers.sh

index f2fbb914e058d2bae0f8e8e455cc20a1626c988e..79a125eb24c2e8a0539a367a05f46d996d9164f0 100644 (file)
@@ -43,7 +43,7 @@ __ktap_test() {
        directive="$3" # optional
 
        local directive_str=
-       [[ ! -z "$directive" ]] && directive_str="# $directive"
+       [ ! -z "$directive" ] && directive_str="# $directive"
 
        echo $result $KTAP_TESTNO $description $directive_str
 
@@ -99,7 +99,7 @@ ktap_exit_fail_msg() {
 ktap_finished() {
        ktap_print_totals
 
-       if [ $(("$KTAP_CNT_PASS" + "$KTAP_CNT_SKIP")) -eq "$KSFT_NUM_TESTS" ]; then
+       if [ $((KTAP_CNT_PASS + KTAP_CNT_SKIP)) -eq "$KSFT_NUM_TESTS" ]; then
                exit "$KSFT_PASS"
        else
                exit "$KSFT_FAIL"