tools: tests: don't use variables in printf format string
authorKent Gibson <warthog618@gmail.com>
Mon, 3 Jun 2024 11:56:25 +0000 (19:56 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 3 Jun 2024 12:02:35 +0000 (14:02 +0200)
Fix shellcheck SC2059[1] - don't use variables in the printf format
string.

[1] https://www.shellcheck.net/wiki/SC2059

Signed-off-by: Kent Gibson <warthog618@gmail.com>
Link: https://lore.kernel.org/r/20240603115628.102616-6-warthog618@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
tools/gpio-tools-test.bash

index efe558b51e1e22f17ecdc8bed421e56d3309fd78..d9930f19a7409132b75bf845576b254c016a4ac6 100755 (executable)
@@ -3048,7 +3048,7 @@ die() {
 oneTimeSetUp() {
        test "$SHUNIT_VERSION" = "$MIN_SHUNIT_VERSION" && return 0
        local FIRST
-       FIRST=$(printf "$SHUNIT_VERSION\n$MIN_SHUNIT_VERSION\n" | sort -Vr | head -1)
+       FIRST=$(printf "%s\n%s\n" "$SHUNIT_VERSION" "$MIN_SHUNIT_VERSION" | sort -Vr | head -1)
        test "$FIRST" = "$MIN_SHUNIT_VERSION" && \
                die "minimum shunit version required is $MIN_SHUNIT_VERSION (current version is $SHUNIT_VERSION"
 }
@@ -3058,7 +3058,7 @@ check_kernel() {
        local CURRENT
        CURRENT=$(uname -r)
 
-       SORTED=$(printf "$REQUIRED\n$CURRENT" | sort -V | head -n 1)
+       SORTED=$(printf "%s\n%s" "$REQUIRED" "$CURRENT" | sort -V | head -n 1)
 
        if [ "$SORTED" != "$REQUIRED" ]
        then