media: gspca: cpia1: Use min macro
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 29 Apr 2024 15:04:57 +0000 (16:04 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 3 May 2024 10:13:45 +0000 (11:13 +0100)
Simplifies the code.

Found by cocci:
drivers/media/usb/gspca/cpia1.c:607:30-31: WARNING opportunity for min()

Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-18-3c4865f5a4b0@chromium.org
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/usb/gspca/cpia1.c

index 5f5fa851ca640dc0ca01a38bf3fb3c975cad69b3..14aaf36cde6e1d4c81e17fa5ef120c68211e01be 100644 (file)
@@ -604,10 +604,8 @@ static int find_over_exposure(int brightness)
        MaxAllowableOverExposure = FLICKER_MAX_EXPOSURE - brightness -
                                   FLICKER_BRIGHTNESS_CONSTANT;
 
-       if (MaxAllowableOverExposure < FLICKER_ALLOWABLE_OVER_EXPOSURE)
-               OverExposure = MaxAllowableOverExposure;
-       else
-               OverExposure = FLICKER_ALLOWABLE_OVER_EXPOSURE;
+       OverExposure = min(MaxAllowableOverExposure,
+                          FLICKER_ALLOWABLE_OVER_EXPOSURE);
 
        return OverExposure;
 }