HID: playstation: DS4: Don't fail on FW/HW version request
authorMax Staudt <max@enpas.org>
Wed, 7 Feb 2024 16:36:44 +0000 (01:36 +0900)
committerJiri Kosina <jkosina@suse.com>
Wed, 3 Apr 2024 19:53:39 +0000 (21:53 +0200)
Some third-party controllers can't report firmware/hardware version.

Unlike for the DualSense, the driver does not use these values for
anything in the DualShock 4 case, but merely exposes them via sysfs.
They will simply be 0x0.

Signed-off-by: Max Staudt <max@enpas.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-playstation.c

index 7f50e13601f08f324bb5536ae6e72916182981ad..df50ca4dab9017960e032b77d0306c744b35b259 100644 (file)
@@ -2558,8 +2558,8 @@ static struct ps_device *dualshock4_create(struct hid_device *hdev)
 
        ret = dualshock4_get_firmware_info(ds4);
        if (ret) {
-               hid_err(hdev, "Failed to get firmware info from DualShock4\n");
-               return ERR_PTR(ret);
+               hid_warn(hdev, "Failed to get firmware info from DualShock4\n");
+               hid_warn(hdev, "HW/FW version data in sysfs will be invalid.\n");
        }
 
        ret = ps_devices_list_add(ps_dev);