arm64: delete dead code in this_cpu_set_vectors()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 19 Apr 2023 07:58:43 +0000 (10:58 +0300)
committerWill Deacon <will@kernel.org>
Thu, 20 Apr 2023 09:44:54 +0000 (10:44 +0100)
The "slot" variable is an enum, and in this context it is an unsigned
int.  So the type means it can never be negative and also we never pass
invalid data to this function.  If something did pass invalid data then
this check would be insufficient protection.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/73859c9e-dea0-4764-bf01-7ae694fa2e37@kili.mountain
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/kernel/proton-pack.c

index fca9cc6f558111624ec681c19d9090878761b5ea..05f40c4e18fda289dd76b7749b59dae009c67c83 100644 (file)
@@ -966,9 +966,6 @@ static void this_cpu_set_vectors(enum arm64_bp_harden_el1_vectors slot)
 {
        const char *v = arm64_get_bp_hardening_vector(slot);
 
-       if (slot < 0)
-               return;
-
        __this_cpu_write(this_cpu_vector, v);
 
        /*