net: sfp: use linkmode_*() rather than open coding
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 15 Nov 2023 11:39:28 +0000 (11:39 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 16 Nov 2023 23:45:04 +0000 (23:45 +0000)
Use the linkmode_*() helpers rather than open coding the calls to the
bitmap operators.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/sfp-bus.c

index 208a9393c2dfde7d439a4f84c1936913333e96bb..6fa679b36290ed528d942b8f3450217ec4a0b1bf 100644 (file)
@@ -328,7 +328,7 @@ void sfp_parse_support(struct sfp_bus *bus, const struct sfp_eeprom_id *id,
         * modules use 2500Mbaud rather than 3100 or 3200Mbaud for
         * 2500BASE-X, so we allow some slack here.
         */
-       if (bitmap_empty(modes, __ETHTOOL_LINK_MODE_MASK_NBITS) && br_nom) {
+       if (linkmode_empty(modes) && br_nom) {
                if (br_min <= 1300 && br_max >= 1200) {
                        phylink_set(modes, 1000baseX_Full);
                        __set_bit(PHY_INTERFACE_MODE_1000BASEX, interfaces);