crash: add prefix for crash dumping messages
authorBaoquan He <bhe@redhat.com>
Thu, 18 Apr 2024 03:58:43 +0000 (11:58 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 8 May 2024 15:41:26 +0000 (08:41 -0700)
Add pr_fmt() to kernel/crash_core.c to add the module name to debugging
message printed as prefix.

And also add prefix 'crashkernel:' to two lines of message printing code
in kernel/crash_reserve.c. In kernel/crash_reserve.c, almost all
debugging messages have 'crashkernel:' prefix or there's keyword
crashkernel at the beginning or in the middle, adding pr_fmt() makes it
redundant.

Link: https://lkml.kernel.org/r/20240418035843.1562887-1-bhe@redhat.com
Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/crash_core.c
kernel/crash_reserve.c

index 78b5dc7cee3ab761314a9328e1ac9ae7afc0fa95..1e7ac977f7c0b48a6be669bf39dff89b3756b214 100644 (file)
@@ -4,6 +4,8 @@
  * Copyright (C) 2002-2004 Eric Biederman  <ebiederm@xmission.com>
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/buildid.h>
 #include <linux/init.h>
 #include <linux/utsname.h>
index 066668799f757286d46a97ae5fee451ef03f8c86..5b2722a93a48caa56176e069ebf8b00fe14ac4b3 100644 (file)
@@ -109,7 +109,7 @@ static int __init parse_crashkernel_mem(char *cmdline,
 
                size = memparse(cur, &tmp);
                if (cur == tmp) {
-                       pr_warn("Memory value expected\n");
+                       pr_warn("crashkernel: Memory value expected\n");
                        return -EINVAL;
                }
                cur = tmp;
@@ -132,7 +132,7 @@ static int __init parse_crashkernel_mem(char *cmdline,
                        cur++;
                        *crash_base = memparse(cur, &tmp);
                        if (cur == tmp) {
-                               pr_warn("Memory value expected after '@'\n");
+                               pr_warn("crahskernel: Memory value expected after '@'\n");
                                return -EINVAL;
                        }
                }