um: Remove unused do_get_thread_area function
authorTiwei Bie <tiwei.btw@antgroup.com>
Tue, 23 Apr 2024 12:58:58 +0000 (20:58 +0800)
committerRichard Weinberger <richard@nod.at>
Tue, 30 Apr 2024 12:18:00 +0000 (14:18 +0200)
It's not used since it was introduced by commit aa6758d4867c ("[PATCH]
uml: implement {get,set}_thread_area for i386"). Now, it's causing a
-Wmissing-prototypes warning:

arch/x86/um/tls_32.c:39:5: warning: no previous prototype for ‘do_get_thread_area’ [-Wmissing-prototypes]
   39 | int do_get_thread_area(struct user_desc *info)
      |     ^~~~~~~~~~~~~~~~~~

The original author also had doubts about whether it should be used.
Considering that 18 years have passed, let's just remove it.

Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/x86/um/tls_32.c

index ba40b1b8e179c9f266fd1cfe29d5ce764caae239..d301deee041ff24c8be206102da5132a64eb8bc4 100644 (file)
@@ -36,22 +36,6 @@ static int do_set_thread_area(struct user_desc *info)
        return ret;
 }
 
-int do_get_thread_area(struct user_desc *info)
-{
-       int ret;
-       u32 cpu;
-
-       cpu = get_cpu();
-       ret = os_get_thread_area(info, userspace_pid[cpu]);
-       put_cpu();
-
-       if (ret)
-               printk(KERN_ERR "PTRACE_GET_THREAD_AREA failed, err = %d, "
-                      "index = %d\n", ret, info->entry_number);
-
-       return ret;
-}
-
 /*
  * sys_get_thread_area: get a yet unused TLS descriptor index.
  * XXX: Consider leaving one free slot for glibc usage at first place. This must
@@ -231,7 +215,6 @@ out:
        return ret;
 }
 
-/* XXX: use do_get_thread_area to read the host value? I'm not at all sure! */
 static int get_tls_entry(struct task_struct *task, struct user_desc *info,
                         int idx)
 {