scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release()
authorBodo Stroesser <bostroesser@gmail.com>
Wed, 10 Mar 2021 18:44:58 +0000 (19:44 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 16 Mar 2021 03:18:37 +0000 (23:18 -0400)
In commit f7c89771d07d ("scsi: target: tcmu: Replace radix_tree with
XArray") the meaning of last parameter of tcmu_blocks_release() was
changed.  So in the callers we should subtract 1 from the previous
parameter.

Unfortunately that change got lost at one of the two places where
tcmu_blocks_release() is called. That does not lead to any problems, but we
should adjust it anyway.

Link: https://lore.kernel.org/r/20210310184458.10741-1-bostroesser@gmail.com
Signed-off-by: Bodo Stroesser <bostroesser@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_user.c

index 9e1b115cb03235118325a6b06584552e6b40fe5f..bdfc057f000c760c5f1683ef5527e6b032d303af 100644 (file)
@@ -1658,7 +1658,7 @@ static void tcmu_dev_kref_release(struct kref *kref)
        xa_destroy(&udev->commands);
        WARN_ON(!all_expired);
 
-       tcmu_blocks_release(&udev->data_blocks, 0, udev->dbi_max + 1);
+       tcmu_blocks_release(&udev->data_blocks, 0, udev->dbi_max);
        bitmap_free(udev->data_bitmap);
        mutex_unlock(&udev->cmdr_lock);