perf annotate-data: Check if 'struct annotation_source' was allocated on 'perf report...
authorNamhyung Kim <namhyung@kernel.org>
Wed, 24 Apr 2024 23:00:15 +0000 (16:00 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Sat, 27 Apr 2024 01:07:21 +0000 (22:07 -0300)
As it removed the sample accounting for code when no symbol sort key is
given for 'perf report' TUI, it might not have allocated the
'struct annotated_source' yet.  Let's check if it's NULL first.

Fixes: 6cdd977ec24e1538 ("perf report: Do not collect sample histogram unnecessarily")
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240424230015.1054013-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/annotate.c

index dca2c08ab8c5996a1f7b7480fe4feb2e864402a8..f5b6b5e5e7571e8bd556d6ba24d9a1b4b8b87b23 100644 (file)
@@ -906,7 +906,7 @@ int symbol__annotate(struct map_symbol *ms, struct evsel *evsel,
        if (parch)
                *parch = arch;
 
-       if (!list_empty(&notes->src->source))
+       if (notes->src && !list_empty(&notes->src->source))
                return 0;
 
        args.arch = arch;