module: tracking: Keep a record of tainted unloaded modules only

This ensures that no module record/or entry is added to the
unloaded_tainted_modules list if it does not carry a taint.

Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
Fixes: 99bd9956551b ("module: Introduce module unload taint tracking")
Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/kernel/module/tracking.c b/kernel/module/tracking.c
index a139e63b6f201ba5c272a07cf7a2fdb89e25e88d..26d812e0761526021087937754e38c4e9011b0d7 100644 (file)
--- a/kernel/module/tracking.c
+++ b/kernel/module/tracking.c
@@ -22,6 +22,9 @@ int try_add_tainted_module(struct module *mod)
 
        module_assert_mutex_or_preempt();
 
+       if (!mod->taints)
+               goto out;
+
        list_for_each_entry_rcu(mod_taint, &unloaded_tainted_modules, list,
                                lockdep_is_held(&module_mutex)) {
                if (!strcmp(mod_taint->name, mod->name) &&