i2c: digicolor: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sat, 27 Apr 2024 20:35:54 +0000 (22:35 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Sun, 5 May 2024 22:56:49 +0000 (00:56 +0200)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-digicolor.c

index 3462f2bc0fa87042a3a4f6f0790ad14b9dbfbab5..737604ae11fc6af045e3ee5cf660926ae025c1a8 100644 (file)
@@ -213,7 +213,7 @@ out:
 static int dc_i2c_xfer_msg(struct dc_i2c *i2c, struct i2c_msg *msg, int first,
                           int last)
 {
-       unsigned long timeout = msecs_to_jiffies(TIMEOUT_MS);
+       unsigned long time_left = msecs_to_jiffies(TIMEOUT_MS);
        unsigned long flags;
 
        spin_lock_irqsave(&i2c->lock, flags);
@@ -227,9 +227,9 @@ static int dc_i2c_xfer_msg(struct dc_i2c *i2c, struct i2c_msg *msg, int first,
        dc_i2c_start_msg(i2c, first);
        spin_unlock_irqrestore(&i2c->lock, flags);
 
-       timeout = wait_for_completion_timeout(&i2c->done, timeout);
+       time_left = wait_for_completion_timeout(&i2c->done, time_left);
        dc_i2c_set_irq(i2c, 0);
-       if (timeout == 0) {
+       if (time_left == 0) {
                i2c->state = STATE_IDLE;
                return -ETIMEDOUT;
        }