mlxsw: core: Trace EMAD events
authorIdo Schimmel <idosch@nvidia.com>
Sun, 6 Dec 2020 08:22:23 +0000 (10:22 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Dec 2020 03:22:14 +0000 (19:22 -0800)
Currently, mlxsw triggers the 'devlink:devlink_hwmsg' tracepoint
whenever a request is sent to the device and whenever a response is
received from it. However, the tracepoint is not triggered when an event
(e.g., port up / down) is received from the device.

Also trace EMAD events in order to log a more complete picture of all
the exchanged hardware messages.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/core.c

index 630109f139a0bff7b4387f3249e6fc5d46dae389..c67825a68a26249870623e6949ae65834accb267 100644 (file)
@@ -160,6 +160,7 @@ struct mlxsw_rx_listener_item {
 
 struct mlxsw_event_listener_item {
        struct list_head list;
+       struct mlxsw_core *mlxsw_core;
        struct mlxsw_event_listener el;
        void *priv;
 };
@@ -2171,11 +2172,16 @@ static void mlxsw_core_event_listener_func(struct sk_buff *skb, u8 local_port,
                                           void *priv)
 {
        struct mlxsw_event_listener_item *event_listener_item = priv;
+       struct mlxsw_core *mlxsw_core;
        struct mlxsw_reg_info reg;
        char *payload;
        char *reg_tlv;
        char *op_tlv;
 
+       mlxsw_core = event_listener_item->mlxsw_core;
+       trace_devlink_hwmsg(priv_to_devlink(mlxsw_core), true, 0,
+                           skb->data, skb->len);
+
        mlxsw_emad_tlv_parse(skb);
        op_tlv = mlxsw_emad_op_tlv(skb);
        reg_tlv = mlxsw_emad_reg_tlv(skb);
@@ -2225,6 +2231,7 @@ int mlxsw_core_event_listener_register(struct mlxsw_core *mlxsw_core,
        el_item = kmalloc(sizeof(*el_item), GFP_KERNEL);
        if (!el_item)
                return -ENOMEM;
+       el_item->mlxsw_core = mlxsw_core;
        el_item->el = *el;
        el_item->priv = priv;