ntfs3: convert to simple_rename_timestamp
authorJeff Layton <jlayton@kernel.org>
Wed, 5 Jul 2023 19:00:38 +0000 (15:00 -0400)
committerChristian Brauner <brauner@kernel.org>
Mon, 10 Jul 2023 08:08:17 +0000 (10:08 +0200)
A rename potentially involves updating 4 different inode timestamps.
Convert to the new simple_rename_timestamp helper function.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jan Kara <jack@suse.cz>
Message-Id: <20230705190309.579783-11-jlayton@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/ntfs3/namei.c

index 70f8c859e0adb43b6c6ba56b6ebfea2563af4b1a..bfd986699f9e50087cbee4768ec70e7ad74e6ca1 100644 (file)
@@ -324,14 +324,11 @@ static int ntfs_rename(struct mnt_idmap *idmap, struct inode *dir,
                /* Restore after failed rename failed too. */
                _ntfs_bad_inode(inode);
        } else if (!err) {
-               inode->i_ctime = dir->i_ctime = dir->i_mtime =
-                       current_time(dir);
+               simple_rename_timestamp(dir, dentry, new_dir, new_dentry);
                mark_inode_dirty(inode);
                mark_inode_dirty(dir);
-               if (dir != new_dir) {
-                       new_dir->i_mtime = new_dir->i_ctime = dir->i_ctime;
+               if (dir != new_dir)
                        mark_inode_dirty(new_dir);
-               }
 
                if (IS_DIRSYNC(dir))
                        ntfs_sync_inode(dir);