ext4: correct return value of ext4_convert_meta_bg
authorKemeng Shi <shikemeng@huaweicloud.com>
Sat, 26 Aug 2023 17:47:02 +0000 (01:47 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 6 Oct 2023 02:32:14 +0000 (22:32 -0400)
Avoid to ignore error in "err".

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Link: https://lore.kernel.org/r/20230826174712.4059355-4-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/resize.c

index 7cbc695b700527b58285521979c8d90c6a1ec4a0..9cb9ed9685996331f9275a4a6aa01d7e97a0a8d0 100644 (file)
@@ -1984,9 +1984,7 @@ static int ext4_convert_meta_bg(struct super_block *sb, struct inode *inode)
 
 errout:
        ret = ext4_journal_stop(handle);
-       if (!err)
-               err = ret;
-       return ret;
+       return err ? err : ret;
 
 invalid_resize_inode:
        ext4_error(sb, "corrupted/inconsistent resize inode");