media: ivsc: csi: Swap SINK and SOURCE pads
authorSakari Ailus <sakari.ailus@linux.intel.com>
Wed, 7 Feb 2024 12:17:09 +0000 (14:17 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 23 Feb 2024 13:33:32 +0000 (14:33 +0100)
This patch swaps SINK and SOURCE pads of the MEI CSI sub-device. While
this does change the UAPI by swapping the pads, the driver has never been
usable in upstream kernel as the Intel IPU6 driver it depends on any
functionality has not yet been merged.

Fixes: 29006e196a56 ("media: pci: intel: ivsc: Add CSI submodule")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/pci/intel/ivsc/mei_csi.c

index 15b905f66ab7298e5d0bd8ae2f0536f0eda2b112..3c74d06a27fad9d0e959cf192af4bc151dc19801 100644 (file)
@@ -71,8 +71,8 @@ enum ivsc_privacy_status {
 };
 
 enum csi_pads {
-       CSI_PAD_SOURCE,
        CSI_PAD_SINK,
+       CSI_PAD_SOURCE,
        CSI_NUM_PADS
 };
 
@@ -587,7 +587,7 @@ static int mei_csi_notify_bound(struct v4l2_async_notifier *notifier,
        csi->remote_pad = pad;
 
        return media_create_pad_link(&subdev->entity, pad,
-                                    &csi->subdev.entity, 1,
+                                    &csi->subdev.entity, CSI_PAD_SINK,
                                     MEDIA_LNK_FL_ENABLED |
                                     MEDIA_LNK_FL_IMMUTABLE);
 }