staging: wlan-ng: remove unnecessary helper function

The function prism2sta_inf_handover() is called by the parent
function prism2sta_ev_info() to print a literal debug information
string using pr_debug(). The debugging utility function can be called
directly within prism2sta_ev_info().

Furthermore, to make the debugging more module-specific, the netdev_dbg()
function is preferred over the generic pr_debug() utility function.

Signed-off-by: Calvince Otieno <calvncce@gmail.com>
Link: https://lore.kernel.org/r/ZSzJuwlEKPBj9kLN@lab-ubuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
index 57180bb71699f7539a051bb3ad46f43b6a6c4dc0..b5e95a3207fe30548d4c301d369e65ea0e94e975 100644 (file)
--- a/drivers/staging/wlan-ng/prism2sta.c
+++ b/drivers/staging/wlan-ng/prism2sta.c
@@ -90,9 +90,6 @@ static int prism2sta_getcardinfo(struct wlandevice *wlandev);
 static int prism2sta_globalsetup(struct wlandevice *wlandev);
 static int prism2sta_setmulticast(struct wlandevice *wlandev,
                                  struct net_device *dev);
-
-static void prism2sta_inf_handover(struct wlandevice *wlandev,
-                                  struct hfa384x_inf_frame *inf);
 static void prism2sta_inf_tallies(struct wlandevice *wlandev,
                                  struct hfa384x_inf_frame *inf);
 static void prism2sta_inf_hostscanresults(struct wlandevice *wlandev,
@@ -922,30 +919,6 @@ exit:
        return result;
 }
 
-/*
- * prism2sta_inf_handover
- *
- * Handles the receipt of a Handover info frame. Should only be present
- * in APs only.
- *
- * Arguments:
- *     wlandev         wlan device structure
- *     inf             ptr to info frame (contents in hfa384x order)
- *
- * Returns:
- *     nothing
- *
- * Side effects:
- *
- * Call context:
- *     interrupt
- */
-static void prism2sta_inf_handover(struct wlandevice *wlandev,
-                                  struct hfa384x_inf_frame *inf)
-{
-       pr_debug("received infoframe:HANDOVER (unhandled)\n");
-}
-
 /*
  * prism2sta_inf_tallies
  *
@@ -1724,7 +1697,8 @@ void prism2sta_ev_info(struct wlandevice *wlandev,
        /* Dispatch */
        switch (inf->infotype) {
        case HFA384x_IT_HANDOVERADDR:
-               prism2sta_inf_handover(wlandev, inf);
+               netdev_dbg(wlandev->netdev,
+                          "received infoframe:HANDOVER (unhandled)\n");
                break;
        case HFA384x_IT_COMMTALLIES:
                prism2sta_inf_tallies(wlandev, inf);