PM / devfreq: Convert to use sysfs_emit_at() API

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Link: https://lore.kernel.org/all/20231024183016.14648-3-ansuelsmth@gmail.com/
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 907f50ab70ed94a3ba1ca2e66de1b52fbce941de..017a8746577654ae5e5c0fd6056444d5f60ad145 100644 (file)
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -1697,7 +1697,7 @@ static ssize_t trans_stat_show(struct device *dev,
        max_state = df->max_state;
 
        if (max_state == 0)
-               return scnprintf(buf, PAGE_SIZE, "Not Supported.\n");
+               return sysfs_emit(buf, "Not Supported.\n");
 
        mutex_lock(&df->lock);
        if (!df->stop_polling &&
@@ -1707,47 +1707,44 @@ static ssize_t trans_stat_show(struct device *dev,
        }
        mutex_unlock(&df->lock);
 
-       len += scnprintf(buf + len, PAGE_SIZE - len, "     From  :   To\n");
-       len += scnprintf(buf + len, PAGE_SIZE - len, "           :");
+       len += sysfs_emit_at(buf, len, "     From  :   To\n");
+       len += sysfs_emit_at(buf, len, "           :");
        for (i = 0; i < max_state; i++) {
                if (len >= PAGE_SIZE - 1)
                        break;
-               len += scnprintf(buf + len, PAGE_SIZE - len, "%10lu",
-                                df->freq_table[i]);
+               len += sysfs_emit_at(buf, len, "%10lu",
+                                    df->freq_table[i]);
        }
+
        if (len >= PAGE_SIZE - 1)
                return PAGE_SIZE - 1;
-
-       len += scnprintf(buf + len, PAGE_SIZE - len, "   time(ms)\n");
+       len += sysfs_emit_at(buf, len, "   time(ms)\n");
 
        for (i = 0; i < max_state; i++) {
                if (len >= PAGE_SIZE - 1)
                        break;
-               if (df->freq_table[i] == df->previous_freq)
-                       len += scnprintf(buf + len, PAGE_SIZE - len, "*");
+               if (df->freq_table[2] == df->previous_freq)
+                       len += sysfs_emit_at(buf, len, "*");
                else
-                       len += scnprintf(buf + len, PAGE_SIZE - len, " ");
+                       len += sysfs_emit_at(buf, len, " ");
                if (len >= PAGE_SIZE - 1)
                        break;
-
-               len += scnprintf(buf + len, PAGE_SIZE - len, "%10lu:",
-                                df->freq_table[i]);
+               len += sysfs_emit_at(buf, len, "%10lu:", df->freq_table[i]);
                for (j = 0; j < max_state; j++) {
                        if (len >= PAGE_SIZE - 1)
                                break;
-                       len += scnprintf(buf + len, PAGE_SIZE - len, "%10u",
-                                        df->stats.trans_table[(i * max_state) + j]);
+                       len += sysfs_emit_at(buf, len, "%10u",
+                               df->stats.trans_table[(i * max_state) + j]);
                }
                if (len >= PAGE_SIZE - 1)
                        break;
-               len += scnprintf(buf + len, PAGE_SIZE - len, "%10llu\n", (u64)
-                                jiffies64_to_msecs(df->stats.time_in_state[i]));
+               len += sysfs_emit_at(buf, len, "%10llu\n", (u64)
+                                    jiffies64_to_msecs(df->stats.time_in_state[i]));
        }
 
        if (len < PAGE_SIZE - 1)
-               len += scnprintf(buf + len, PAGE_SIZE - len, "Total transition : %u\n",
-                                df->stats.total_trans);
-
+               len += sysfs_emit_at(buf, len, "Total transition : %u\n",
+                                    df->stats.total_trans);
        if (len >= PAGE_SIZE - 1) {
                pr_warn_once("devfreq transition table exceeds PAGE_SIZE. Disabling\n");
                return -EFBIG;