fbdev/sunxvr2500: Use fbdev I/O helpers
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 3 Aug 2023 18:36:07 +0000 (20:36 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 4 Aug 2023 13:54:38 +0000 (15:54 +0200)
Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-43-tzimmermann@suse.de
drivers/video/fbdev/Kconfig
drivers/video/fbdev/sunxvr2500.c

index 01f67b21df0607b161d8619630326dbca85dd308..f5ce8d6d1247ae907c2e8b2d32d9930bf8c21c40 100644 (file)
@@ -617,9 +617,7 @@ config FB_XVR500
 config FB_XVR2500
        bool "Sun XVR-2500 3DLABS Wildcat support"
        depends on (FB = y) && PCI && SPARC64
-       select FB_CFB_FILLRECT
-       select FB_CFB_COPYAREA
-       select FB_CFB_IMAGEBLIT
+       select FB_IOMEM_HELPERS
        select VIDEO_NOMODESET
        help
          This is the framebuffer device for the Sun XVR-2500 and similar
index 8765add3a5be4dc946af85c763804996c7d2b0dc..47b85e4959dd671147df83f0a42208a58a65030d 100644 (file)
@@ -66,10 +66,8 @@ static int s3d_setcolreg(unsigned regno,
 
 static const struct fb_ops s3d_ops = {
        .owner                  = THIS_MODULE,
+       FB_DEFAULT_IOMEM_OPS,
        .fb_setcolreg           = s3d_setcolreg,
-       .fb_fillrect            = cfb_fillrect,
-       .fb_copyarea            = cfb_copyarea,
-       .fb_imageblit           = cfb_imageblit,
 };
 
 static int s3d_set_fbinfo(struct s3d_info *sp)