writeback: remove {set,clear}_wb_congested
authorChristoph Hellwig <hch@lst.de>
Wed, 1 Jul 2020 09:06:20 +0000 (11:06 +0200)
committerJens Axboe <axboe@kernel.dk>
Wed, 8 Jul 2020 23:05:53 +0000 (17:05 -0600)
Just merge them into their only callers.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/linux/backing-dev-defs.h
mm/backing-dev.c

index 90a7e844a098f3900bd83cf339b4015923e869af..cc5aa1f32b91f0fdf55494df49f0c71ace2eafea 100644 (file)
@@ -232,18 +232,8 @@ enum {
        BLK_RW_SYNC     = 1,
 };
 
-void clear_wb_congested(struct bdi_writeback_congested *congested, int sync);
-void set_wb_congested(struct bdi_writeback_congested *congested, int sync);
-
-static inline void clear_bdi_congested(struct backing_dev_info *bdi, int sync)
-{
-       clear_wb_congested(bdi->wb.congested, sync);
-}
-
-static inline void set_bdi_congested(struct backing_dev_info *bdi, int sync)
-{
-       set_wb_congested(bdi->wb.congested, sync);
-}
+void clear_bdi_congested(struct backing_dev_info *bdi, int sync);
+void set_bdi_congested(struct backing_dev_info *bdi, int sync);
 
 struct wb_lock_cookie {
        bool locked;
index d382272bcc3100f50e2a4ce8de07dc8d455d7e33..3ebe5144a102f2a26b8aa32b30540aab48a2b366 100644 (file)
@@ -1047,29 +1047,29 @@ static wait_queue_head_t congestion_wqh[2] = {
        };
 static atomic_t nr_wb_congested[2];
 
-void clear_wb_congested(struct bdi_writeback_congested *congested, int sync)
+void clear_bdi_congested(struct backing_dev_info *bdi, int sync)
 {
        wait_queue_head_t *wqh = &congestion_wqh[sync];
        enum wb_congested_state bit;
 
        bit = sync ? WB_sync_congested : WB_async_congested;
-       if (test_and_clear_bit(bit, &congested->state))
+       if (test_and_clear_bit(bit, &bdi->wb.congested->state))
                atomic_dec(&nr_wb_congested[sync]);
        smp_mb__after_atomic();
        if (waitqueue_active(wqh))
                wake_up(wqh);
 }
-EXPORT_SYMBOL(clear_wb_congested);
+EXPORT_SYMBOL(clear_bdi_congested);
 
-void set_wb_congested(struct bdi_writeback_congested *congested, int sync)
+void set_bdi_congested(struct backing_dev_info *bdi, int sync)
 {
        enum wb_congested_state bit;
 
        bit = sync ? WB_sync_congested : WB_async_congested;
-       if (!test_and_set_bit(bit, &congested->state))
+       if (!test_and_set_bit(bit, &bdi->wb.congested->state))
                atomic_inc(&nr_wb_congested[sync]);
 }
-EXPORT_SYMBOL(set_wb_congested);
+EXPORT_SYMBOL(set_bdi_congested);
 
 /**
  * congestion_wait - wait for a backing_dev to become uncongested