ASoC: wm_adsp: simplify return value
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 11 Mar 2021 00:43:31 +0000 (18:43 -0600)
committerMark Brown <broonie@kernel.org>
Thu, 11 Mar 2021 13:24:18 +0000 (13:24 +0000)
cppcheck warning:

sound/soc/codecs/wm_adsp.c:2092:9: warning: Identical condition and
return expression 'ret', return value is always 0
[identicalConditionAfterEarlyExit]
 return ret;
        ^
sound/soc/codecs/wm_adsp.c:2070:6: note: If condition 'ret' is true,
the function will return/exit
 if (ret)
     ^
sound/soc/codecs/wm_adsp.c:2092:9: note: Returning identical
expression 'ret'
 return ret;
        ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210311004332.120901-10-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp.c

index 070ca7d8c661003dec4dba893ef21a40e945c58e..3dc119daf2f67eafd11f77d708bacb3744208d98 100644 (file)
@@ -2079,7 +2079,7 @@ int wm_adsp_write_ctl(struct wm_adsp *dsp, const char *name, int type,
        snd_ctl_notify(dsp->component->card->snd_card,
                       SNDRV_CTL_EVENT_MASK_VALUE, &kcontrol->id);
 
-       return ret;
+       return 0;
 }
 EXPORT_SYMBOL_GPL(wm_adsp_write_ctl);