perf beauty sockaddr: Fix augmented syscall format warning
authorCengiz Can <cengiz@kernel.wtf>
Mon, 13 Jan 2020 17:44:39 +0000 (20:44 +0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 14 Jan 2020 15:42:26 +0000 (12:42 -0300)
The sockaddr related examples given in
`tools/perf/examples/bpf/augmented_syscalls.c` almost always use `long`s
to represent most of their fields.

However, `size_t syscall_arg__scnprintf_sockaddr(..)` has a `scnprintf`
call that uses `"%#x"` as format string.

This throws a warning (whenever the syscall argument is `unsigned
long`).

Added `l` identifier to indicate that the `arg->value` is an unsigned
long.

Not sure about the complications of this with x86 though.

Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20200113174438.102975-1-cengiz@kernel.wtf
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/trace/beauty/sockaddr.c

index 173c8f760763048a46bbbf9cafa0be7c52319fb9..e0c13e6a5788a8e6e824bb9bee9ab42137639a50 100644 (file)
@@ -72,5 +72,5 @@ size_t syscall_arg__scnprintf_sockaddr(char *bf, size_t size, struct syscall_arg
        if (arg->augmented.args)
                return syscall_arg__scnprintf_augmented_sockaddr(arg, bf, size);
 
-       return scnprintf(bf, size, "%#x", arg->val);
+       return scnprintf(bf, size, "%#lx", arg->val);
 }