scsi: mac_scsi: Mark driver struct with __refdata to prevent section mismatch
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 29 Mar 2024 21:11:44 +0000 (22:11 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 6 Apr 2024 01:11:44 +0000 (21:11 -0400)
As described in the added code comment, a reference to .exit.text is ok for
drivers registered via module_platform_driver_probe(). Make this explicit
to prevent the following section mismatch warning

WARNING: modpost: drivers/scsi/mac_scsi: section mismatch in reference: mac_scsi_driver+0x8 (section: .data) -> mac_scsi_remove (section: .exit.text)

that triggers on an allmodconfig W=1 build.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/e41d10906948a980e985f6065485445d9bbbd2f7.1711746359.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mac_scsi.c

index 181f16899fdc239d527d7823a16f1a8bbaaaa229..a402c4dc4645d3ac894b39469837d9524a9ba6bb 100644 (file)
@@ -534,7 +534,13 @@ static void __exit mac_scsi_remove(struct platform_device *pdev)
        scsi_host_put(instance);
 }
 
-static struct platform_driver mac_scsi_driver = {
+/*
+ * mac_scsi_remove() lives in .exit.text. For drivers registered via
+ * module_platform_driver_probe() this is ok because they cannot get unbound at
+ * runtime. So mark the driver struct with __refdata to prevent modpost
+ * triggering a section mismatch warning.
+ */
+static struct platform_driver mac_scsi_driver __refdata = {
        .remove_new = __exit_p(mac_scsi_remove),
        .driver = {
                .name   = DRV_MODULE_NAME,