perf lock: Fix a memory leak on an error path
authorzhaimingbing <zhaimingbing@cmss.chinamobile.com>
Fri, 24 Nov 2023 09:26:57 +0000 (17:26 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 27 Nov 2023 13:21:27 +0000 (10:21 -0300)
if a strdup-ed string is NULL,the allocated memory needs freeing.

Signed-off-by: zhaimingbing <zhaimingbing@cmss.chinamobile.com>
Acked-by: Ingo Molnar <mingo@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Li Dong <lidong@vivo.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/r/20231124092657.10392-1-zhaimingbing@cmss.chinamobile.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-lock.c

index a3ff2f4edbaa5064b040b256eaee1361a34122e5..230461280e4525a612a6842c3a99c7b1a1225929 100644 (file)
@@ -2285,8 +2285,10 @@ setup_args:
                else
                        ev_name = strdup(contention_tracepoints[j].name);
 
-               if (!ev_name)
+               if (!ev_name) {
+                       free(rec_argv);
                        return -ENOMEM;
+               }
 
                rec_argv[i++] = "-e";
                rec_argv[i++] = ev_name;