firmware/psci: fix application of sizeof to pointer
authorjing yangyang <cgel.zte@gmail.com>
Fri, 20 Aug 2021 02:30:16 +0000 (19:30 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:15:53 +0000 (19:15 +0100)
commit 2ac5fb35cd520ab1851c9a4816c523b65276052f upstream.

sizeof when applied to a pointer typed expression gives the size of
the pointer.

./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer

This issue was detected with the help of Coccinelle.

Fixes: 7401056de5f8 ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests")
Cc: stable@vger.kernel.org
Reported-by: Zeal Robot <zealci@zte.com.cn>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/psci/psci_checker.c

index 9a369a2eda71d2614b21b18e407b0bbca0564afd..116eb465cdb4220476663f6bf49296842c1d6c2a 100644 (file)
@@ -155,7 +155,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups)
        if (!alloc_cpumask_var(&tmp, GFP_KERNEL))
                return -ENOMEM;
 
-       cpu_groups = kcalloc(nb_available_cpus, sizeof(cpu_groups),
+       cpu_groups = kcalloc(nb_available_cpus, sizeof(*cpu_groups),
                             GFP_KERNEL);
        if (!cpu_groups) {
                free_cpumask_var(tmp);