RDMA/rtrs: Kill the put label in rtrs_srv_create_once_sysfs_root_folders
authorGuoqing Jiang <guoqing.jiang@cloud.ionos.com>
Thu, 25 Mar 2021 15:32:54 +0000 (16:32 +0100)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 1 Apr 2021 18:40:17 +0000 (15:40 -0300)
We can remove the label after move put_device to the right place.

Link: https://lore.kernel.org/r/20210325153308.1214057-9-gi-oh.kim@ionos.com
Signed-off-by: Guoqing Jiang <guoqing.jiang@ionos.com>
Reviewed-by: Danil Kipnis <danil.kipnis@ionos.com>
Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c

index 126a96e75c6217cb7f2032c132a4ae38bcb06e94..1599d42d7302f5aafcbd0a73a0fb5e44422eebd3 100644 (file)
@@ -176,7 +176,8 @@ static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess)
        err = device_add(&srv->dev);
        if (err) {
                pr_err("device_add(): %d\n", err);
-               goto put;
+               put_device(&srv->dev);
+               goto unlock;
        }
        srv->kobj_paths = kobject_create_and_add("paths", &srv->dev.kobj);
        if (!srv->kobj_paths) {
@@ -188,10 +189,6 @@ static int rtrs_srv_create_once_sysfs_root_folders(struct rtrs_srv_sess *sess)
        }
        dev_set_uevent_suppress(&srv->dev, false);
        kobject_uevent(&srv->dev.kobj, KOBJ_ADD);
-       goto unlock;
-
-put:
-       put_device(&srv->dev);
 unlock:
        mutex_unlock(&srv->paths_mutex);