staging: r8188eu: DYNAMIC_BB_ANT_DIV is not used
authorMartin Kaiser <martin@kaiser.cx>
Mon, 21 Mar 2022 20:30:29 +0000 (21:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Apr 2022 05:33:46 +0000 (07:33 +0200)
Remove the DYNAMIC_BB_ANT_DIV capability. It's cleared in one place but
never checked.

DYNAMIC_BB_ANT_DIV is part of podmpriv->SupportAbility, there are no
users that check SupportAbility as a whole and use DYNAMIC_BB_ANT_DIV
implicitly.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220321203031.143486-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/usb_halinit.c
drivers/staging/r8188eu/include/rtw_mlme_ext.h

index dda8715beb0732f9c439a6d836743a1e1f76e7ee..599d930a59277b31bf5fce0d7254a3273b7a8b03 100644 (file)
@@ -1433,8 +1433,6 @@ void SetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariab
                                podmpriv->SupportAbility  &= (~DYNAMIC_BB_DIG);
                        } else if (dm_func == 3) {/* disable tx power tracking */
                                podmpriv->SupportAbility  &= (~DYNAMIC_RF_CALIBRATION);
-                       } else if (dm_func == 5) {/* disable antenna diversity */
-                               podmpriv->SupportAbility  &= (~DYNAMIC_BB_ANT_DIV);
                        } else if (dm_func == 6) {/* turn on all dynamic func */
                                if (!(podmpriv->SupportAbility  & DYNAMIC_BB_DIG)) {
                                        struct rtw_dig *pDigTable = &podmpriv->DM_DigTable;
index 703fb9f2409d6bdae06f5c2f00a71fc6c1b56959..9b9c81fe85432106aafabbce55ec3649762881e7 100644 (file)
@@ -31,8 +31,6 @@
 /*  BB ODM section BIT 0-15 */
 #define        DYNAMIC_BB_DIG                          BIT(0)
 
-#define                DYNAMIC_BB_ANT_DIV                      BIT(6)
-
 #define                DYNAMIC_RF_CALIBRATION          BIT(26)
 
 #define                DYNAMIC_ALL_FUNC_ENABLE         0xFFFFFFF