projects
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a62c617
)
qapi: Replace qmp_dispatch()'s TODO comment by an explanation
author
Markus Armbruster
<armbru@redhat.com>
Tue, 17 Mar 2020 11:54:49 +0000
(12:54 +0100)
committer
Markus Armbruster
<armbru@redhat.com>
Tue, 17 Mar 2020 20:41:33 +0000
(21:41 +0100)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <
20200317115459
.31821-25-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
qapi/qmp-dispatch.c
patch
|
blob
|
history
diff --git
a/qapi/qmp-dispatch.c
b/qapi/qmp-dispatch.c
index 91e50fa0dd4b22a81bd90cba0de7d9f0bc7117f7..44fc368d617ee2dc6459f988168a089981df72fe 100644
(file)
--- a/
qapi/qmp-dispatch.c
+++ b/
qapi/qmp-dispatch.c
@@
-162,7
+162,11
@@
QDict *qmp_dispatch(QmpCommandList *cmds, QObject *request,
g_assert(!ret);
return NULL;
} else if (!ret) {
- /* TODO turn into assertion */
+ /*
+ * When the command's schema has no 'returns', cmd->fn()
+ * leaves @ret null. The QMP spec calls for an empty object
+ * then; supply it.
+ */
ret = QOBJECT(qdict_new());
}