projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6edc794
)
pinctrl: samsung: Update error check for unsigned variables
author
Tushar Behera
<tushar.behera@linaro.org>
Mon, 19 Nov 2012 00:45:19 +0000
(09:45 +0900)
committer
Kukjin Kim
<kgene.kim@samsung.com>
Mon, 19 Nov 2012 01:03:35 +0000
(10:03 +0900)
Checking '< 0' for unsigned variables always returns false. For error
codes, use IS_ERR_VALUE() instead.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
drivers/pinctrl/pinctrl-samsung.c
patch
|
blob
|
history
diff --git
a/drivers/pinctrl/pinctrl-samsung.c
b/drivers/pinctrl/pinctrl-samsung.c
index 81c9896d4f64e16d5c3afc2abbac2ae3a5a9d1f8..3b52c17c4fd216e5ba20e87da976c70c41e1e316 100644
(file)
--- a/
drivers/pinctrl/pinctrl-samsung.c
+++ b/
drivers/pinctrl/pinctrl-samsung.c
@@
-560,7
+560,7
@@
static int __devinit samsung_pinctrl_parse_dt_pins(struct platform_device *pdev,
const char *pin_name;
*npins = of_property_count_strings(cfg_np, "samsung,pins");
- if (
*npins < 0
) {
+ if (
IS_ERR_VALUE(*npins)
) {
dev_err(dev, "invalid pin list in %s node", cfg_np->name);
return -EINVAL;
}