sunrpc: remove unused bc_up operation from rpc_xprt_ops
authorVasily Averin <vvs@virtuozzo.com>
Mon, 24 Dec 2018 11:45:25 +0000 (14:45 +0300)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 28 Dec 2018 02:01:41 +0000 (21:01 -0500)
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
include/linux/sunrpc/xprt.h
net/sunrpc/xprtrdma/backchannel.c
net/sunrpc/xprtrdma/transport.c
net/sunrpc/xprtrdma/xprt_rdma.h
net/sunrpc/xprtsock.c

index a4ab4f8d914043a63a5b31306990c3b8dce64f04..ad7e910b119dff15bf09af1e614577e05499c9d3 100644 (file)
@@ -157,7 +157,6 @@ struct rpc_xprt_ops {
        void            (*inject_disconnect)(struct rpc_xprt *xprt);
        int             (*bc_setup)(struct rpc_xprt *xprt,
                                    unsigned int min_reqs);
-       int             (*bc_up)(struct svc_serv *serv, struct net *net);
        size_t          (*bc_maxpayload)(struct rpc_xprt *xprt);
        void            (*bc_free_rqst)(struct rpc_rqst *rqst);
        void            (*bc_destroy)(struct rpc_xprt *xprt,
index e5b367a3e517ac605efa0802976afebd8f365149..edba0d35776b9407f744f8fced417964c7e7570c 100644 (file)
@@ -113,26 +113,6 @@ out_err:
        return -ENOMEM;
 }
 
-/**
- * xprt_rdma_bc_up - Create transport endpoint for backchannel service
- * @serv: server endpoint
- * @net: network namespace
- *
- * The "xprt" is an implied argument: it supplies the name of the
- * backchannel transport class.
- *
- * Returns zero on success, negative errno on failure
- */
-int xprt_rdma_bc_up(struct svc_serv *serv, struct net *net)
-{
-       int ret;
-
-       ret = svc_create_xprt(serv, "rdma-bc", net, PF_INET, 0, 0);
-       if (ret < 0)
-               return ret;
-       return 0;
-}
-
 /**
  * xprt_rdma_bc_maxpayload - Return maximum backchannel message size
  * @xprt: transport
index ae2a83828953706e9b5cde03b8a3449b9aeb3df1..9141068693fafab2b28e68c8130698b70e54bc3d 100644 (file)
@@ -827,7 +827,6 @@ static const struct rpc_xprt_ops xprt_rdma_procs = {
        .inject_disconnect      = xprt_rdma_inject_disconnect,
 #if defined(CONFIG_SUNRPC_BACKCHANNEL)
        .bc_setup               = xprt_rdma_bc_setup,
-       .bc_up                  = xprt_rdma_bc_up,
        .bc_maxpayload          = xprt_rdma_bc_maxpayload,
        .bc_free_rqst           = xprt_rdma_bc_free_rqst,
        .bc_destroy             = xprt_rdma_bc_destroy,
index a13ccb643ce07e0a3838079f914a20ee586c417e..9218dbebedce2824eaedf1cc11a20364552ea538 100644 (file)
@@ -661,7 +661,6 @@ void xprt_rdma_cleanup(void);
  */
 #if defined(CONFIG_SUNRPC_BACKCHANNEL)
 int xprt_rdma_bc_setup(struct rpc_xprt *, unsigned int);
-int xprt_rdma_bc_up(struct svc_serv *, struct net *);
 size_t xprt_rdma_bc_maxpayload(struct rpc_xprt *);
 int rpcrdma_bc_post_recv(struct rpcrdma_xprt *, unsigned int);
 void rpcrdma_bc_receive_call(struct rpcrdma_xprt *, struct rpcrdma_rep *);
index ae77c71c1f640c32fd8d673934be412da9da0189..5b392b3df90a20fdad46122c9605e7080bef5543 100644 (file)
@@ -1405,17 +1405,6 @@ static void xs_tcp_force_close(struct rpc_xprt *xprt)
 }
 
 #if defined(CONFIG_SUNRPC_BACKCHANNEL)
-static int xs_tcp_bc_up(struct svc_serv *serv, struct net *net)
-{
-       int ret;
-
-       ret = svc_create_xprt(serv, "tcp-bc", net, PF_INET, 0,
-                             SVC_SOCK_ANONYMOUS);
-       if (ret < 0)
-               return ret;
-       return 0;
-}
-
 static size_t xs_tcp_bc_maxpayload(struct rpc_xprt *xprt)
 {
        return PAGE_SIZE;
@@ -2672,7 +2661,6 @@ static const struct rpc_xprt_ops xs_tcp_ops = {
        .inject_disconnect      = xs_inject_disconnect,
 #ifdef CONFIG_SUNRPC_BACKCHANNEL
        .bc_setup               = xprt_setup_bc,
-       .bc_up                  = xs_tcp_bc_up,
        .bc_maxpayload          = xs_tcp_bc_maxpayload,
        .bc_free_rqst           = xprt_free_bc_rqst,
        .bc_destroy             = xprt_destroy_bc,