drm/rockchip: vop2: Add error check to devm_regmap_init_mmio
authorAlfredo Cruz <alfredo.carlon@gmail.com>
Wed, 22 Mar 2023 22:44:11 +0000 (23:44 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Wed, 22 Mar 2023 23:18:58 +0000 (00:18 +0100)
devm_regmap_init_mmio() may return an invalid pointer in case of an error.
This patch adds the corresponding IS_ERR check to vop2->map.

Signed-off-by: Alfredo Cruz <alfredo.carlon@gmail.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230322224411.15612-1-alfredo.carlon@gmail.com
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c

index fce992c3506f807a8142572754540748fe9b513a..38554ca2fc392e44412caccb00064eb9cb602bd9 100644 (file)
@@ -2679,6 +2679,8 @@ static int vop2_bind(struct device *dev, struct device *master, void *data)
        vop2->len = resource_size(res);
 
        vop2->map = devm_regmap_init_mmio(dev, vop2->regs, &vop2_regmap_config);
+       if (IS_ERR(vop2->map))
+               return PTR_ERR(vop2->map);
 
        ret = vop2_win_init(vop2);
        if (ret)