misc: ti-st: make array read_ver_cmd static, shrinks object size
authorColin Ian King <colin.king@canonical.com>
Thu, 29 Nov 2018 23:15:56 +0000 (23:15 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Dec 2018 14:53:15 +0000 (15:53 +0100)
Don't populate the const array read_ver_cmd on the stack but instead
make it static. Makes the object code smaller by 42 bytes:

Before:
   text    data     bss     dec     hex filename
  17262    6928     192   24382    5f3e drivers/misc/ti-st/st_kim.o

After:
   text    data     bss     dec     hex filename
  17156    6992     192   24340    5f14 drivers/misc/ti-st/st_kim.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/ti-st/st_kim.c

index e47abf173626563d031a53f704799facd89668ec..e7cfdbd1f66d5241b7466547bbaa29e63c534afb 100644 (file)
@@ -211,7 +211,7 @@ static void kim_int_recv(struct kim_data_s *kim_gdata,
 static long read_local_version(struct kim_data_s *kim_gdata, char *bts_scr_name)
 {
        unsigned short version = 0, chip = 0, min_ver = 0, maj_ver = 0;
-       const char read_ver_cmd[] = { 0x01, 0x01, 0x10, 0x00 };
+       static const char read_ver_cmd[] = { 0x01, 0x01, 0x10, 0x00 };
        long timeout;
 
        pr_debug("%s", __func__);