wifi: brcmsmac: fix gnu_printf warnings
authorKalle Valo <kvalo@kernel.org>
Tue, 13 Jun 2023 14:09:16 +0000 (17:09 +0300)
committerKalle Valo <kvalo@kernel.org>
Fri, 16 Jun 2023 09:24:15 +0000 (12:24 +0300)
With GCC 13.1 and W=1 brcmsmac has warnings like this:

./include/trace/stages/stage5_get_offsets.h:23:31: warning: function 'trace_event_get_offsets_brcms_dbg' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]

Add a workaround which disables -Wsuggest-attribute=format in
brcms_trace_brcmsmac_msg.h. I see similar workarounds in other drivers as well.

Compile tested only.

Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230613140918.389690-3-kvalo@kernel.org
drivers/net/wireless/broadcom/brcm80211/brcmsmac/brcms_trace_brcmsmac_msg.h

index 4884564203530b2b056978f8d2f0e82f195faca8..42b0a91656c45f9f3969282d2926771e8e890cca 100644 (file)
 
 #define MAX_MSG_LEN    100
 
+#pragma GCC diagnostic push
+#ifndef __clang__
+#pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
+#endif
+
 DECLARE_EVENT_CLASS(brcms_msg_event,
        TP_PROTO(struct va_format *vaf),
        TP_ARGS(vaf),
@@ -71,6 +76,9 @@ TRACE_EVENT(brcms_dbg,
        ),
        TP_printk("%s: %s", __get_str(func), __get_str(msg))
 );
+
+#pragma GCC diagnostic pop
+
 #endif /* __TRACE_BRCMSMAC_MSG_H */
 
 #ifdef CONFIG_BRCM_TRACING