serial: 8250_pci: remove redundant assignment to tmp after the mask operation
authorColin Ian King <colin.i.king@gmail.com>
Sun, 5 Dec 2021 23:28:22 +0000 (23:28 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Dec 2021 17:01:39 +0000 (18:01 +0100)
The variable tmp is being masked with a bitmask and the value is being
written to port base + 0x3c.  However, the masked value is being written
back to tmp and tmp is never used after this. The assignmentment is
redundant, replace the &= operator with just &.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewesd-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211205232822.110099-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_pci.c

index 60f8fffdfd7765ada0d9a310fa211a088d746ce6..81aac3c25eadd9777e88391d20a3001fe23d95ec 100644 (file)
@@ -1278,7 +1278,7 @@ static int pci_quatech_init(struct pci_dev *dev)
                        outl(inl(base + 0x38) | 0x00002000, base + 0x38);
                        tmp = inl(base + 0x3c);
                        outl(tmp | 0x01000000, base + 0x3c);
-                       outl(tmp &= ~0x01000000, base + 0x3c);
+                       outl(tmp & ~0x01000000, base + 0x3c);
                }
        }
        return 0;