drm/msm/dpu: capture snapshot on the first commit_done timeout

In order to debug commit_done timeouts, capture the devcoredump state
when the first timeout occurs after the encoder has been enabled.

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/579850/
Link: https://lore.kernel.org/r/20240226-fd-dpu-debug-timeout-v4-3-51eec83dde23@linaro.org

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index e8d123327c4167087320cb9941cdce1129cef9a9..9a14d2232e4a0ad2c0d4ad0d4b9136b6ddf9d5d8 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -126,6 +126,8 @@ enum dpu_enc_rc_states {
  * @base:              drm_encoder base class for registration with DRM
  * @enc_spinlock:      Virtual-Encoder-Wide Spin Lock for IRQ purposes
  * @enabled:           True if the encoder is active, protected by enc_lock
+ * @commit_done_timedout: True if there has been a timeout on commit after
+ *                     enabling the encoder.
  * @num_phys_encs:     Actual number of physical encoders contained.
  * @phys_encs:         Container of physical encoders managed.
  * @cur_master:                Pointer to the current master in this mode. Optimization
@@ -172,6 +174,7 @@ struct dpu_encoder_virt {
        spinlock_t enc_spinlock;
 
        bool enabled;
+       bool commit_done_timedout;
 
        unsigned int num_phys_encs;
        struct dpu_encoder_phys *phys_encs[MAX_PHYS_ENCODERS_PER_VIRTUAL];
@@ -1269,6 +1272,9 @@ static void dpu_encoder_virt_atomic_enable(struct drm_encoder *drm_enc,
        atomic_set(&dpu_enc->frame_done_timeout_cnt, 0);
 
        mutex_lock(&dpu_enc->enc_lock);
+
+       dpu_enc->commit_done_timedout = false;
+
        cur_mode = &dpu_enc->base.crtc->state->adjusted_mode;
 
        dpu_enc->wide_bus_en = dpu_encoder_is_widebus_enabled(drm_enc);
@@ -2553,6 +2559,10 @@ int dpu_encoder_wait_for_commit_done(struct drm_encoder *drm_enc)
                        DPU_ATRACE_BEGIN("wait_for_commit_done");
                        ret = phys->ops.wait_for_commit_done(phys);
                        DPU_ATRACE_END("wait_for_commit_done");
+                       if (ret == -ETIMEDOUT && !dpu_enc->commit_done_timedout) {
+                               dpu_enc->commit_done_timedout = true;
+                               msm_disp_snapshot_state(drm_enc->dev);
+                       }
                        if (ret)
                                return ret;
                }