media: atomisp: remove unused attribute argument from ia_css_frame_map()
authorHans de Goede <hdegoede@redhat.com>
Wed, 15 Jun 2022 20:50:11 +0000 (21:50 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 8 Jul 2022 15:22:39 +0000 (16:22 +0100)
ia_css_frame_map() has only one caller which passes a hardcoded 0
for the attribute argument, drop it.

Link: https://lore.kernel.org/linux-media/20220615205037.16549-15-hdegoede@redhat.com
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_ioctl.c
drivers/staging/media/atomisp/pci/ia_css_frame_public.h
drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c

index 8fd470efd658e3f0bd017b1505d60d4653468dbe..fef7b08965b35f92cf2eccc0dc0673eb18c11589 100644 (file)
@@ -1371,7 +1371,7 @@ static int atomisp_qbuf(struct file *file, void *fh, struct v4l2_buffer *buf)
 
                ret = ia_css_frame_map(&handle, &frame_info,
                                            (void __user *)buf->m.userptr,
-                                           0, pgnr);
+                                           pgnr);
                if (ret) {
                        dev_err(isp->dev, "Failed to map user buffer\n");
                        goto error;
index 8f05af6d4cc95ed71b84eb7d920287638c62daac..514d933f934df422a552dff94fab10a3377c9085 100644 (file)
@@ -295,7 +295,6 @@ int
 ia_css_frame_map(struct ia_css_frame **frame,
                 const struct ia_css_frame_info *info,
                 const void __user *data,
-                u16 attribute,
                 unsigned int pgnr);
 
 /* @brief Unmap a CSS frame structure.
index b748b133f01e0ab9ba1a6362f1f953baa498fd93..f3b80650e1ad1b11955f23798d2ff80e5b5be49b 100644 (file)
@@ -146,7 +146,6 @@ int ia_css_frame_allocate(struct ia_css_frame **frame,
 int ia_css_frame_map(struct ia_css_frame **frame,
                                 const struct ia_css_frame_info *info,
                                 const void __user *data,
-                                u16 attribute,
                                 unsigned int pgnr)
 {
        int err = 0;
@@ -172,9 +171,7 @@ int ia_css_frame_map(struct ia_css_frame **frame,
                goto error;
        }
 
-       me->data = hmm_alloc(me->data_bytes, HMM_BO_USER, 0, data,
-                            attribute & ATOMISP_MAP_FLAG_CACHED);
-
+       me->data = hmm_alloc(me->data_bytes, HMM_BO_USER, 0, data, 0);
        if (me->data == mmgr_NULL)
                err = -EINVAL;