staging: rtl8712: Replace function r8712_dequeue_cmd()
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Wed, 26 Jun 2019 06:09:41 +0000 (11:39 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 1 Jul 2019 08:44:06 +0000 (10:44 +0200)
Remove function r8712_dequeue_cmd as all it does is call _dequeue_cmd.
Rename _dequeue_cmd to r8712_dequeue_cmd and change its type from static
to non-static to maintain compatibility with call sites.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl871x_cmd.c

index 37cc18581e84eef2818e0c0f127e55b591cd5075..26b618008fcfe731e77bb2b0e8ced6eb4346991e 100644 (file)
@@ -126,7 +126,7 @@ void r8712_enqueue_cmd(struct cmd_priv *pcmdpriv, struct cmd_obj *obj)
        complete(&pcmdpriv->cmd_queue_comp);
 }
 
-static struct cmd_obj *_dequeue_cmd(struct  __queue *queue)
+struct cmd_obj *r8712_dequeue_cmd(struct  __queue *queue)
 {
        unsigned long irqL;
        struct cmd_obj *obj;
@@ -156,11 +156,6 @@ void r8712_enqueue_cmd_ex(struct cmd_priv *pcmdpriv, struct cmd_obj *obj)
        complete(&pcmdpriv->cmd_queue_comp);
 }
 
-struct cmd_obj *r8712_dequeue_cmd(struct  __queue *queue)
-{
-       return _dequeue_cmd(queue);
-}
-
 void r8712_free_cmd_obj(struct cmd_obj *pcmd)
 {
        if ((pcmd->cmdcode != _JoinBss_CMD_) &&