KVM: arm64: Initialize the kvm host data's fpsimd_state pointer in pKVM
authorFuad Tabba <tabba@google.com>
Tue, 23 Apr 2024 15:05:09 +0000 (16:05 +0100)
committerMarc Zyngier <maz@kernel.org>
Wed, 1 May 2024 15:46:58 +0000 (16:46 +0100)
Since the host_fpsimd_state has been removed from kvm_vcpu_arch,
it isn't pointing to the hyp's version of the host fp_regs in
protected mode.

Initialize the host_data fpsimd_state point to the host_data's
context fp_regs on pKVM initialization.

Fixes: 51e09b5572d6 ("KVM: arm64: Exclude host_fpsimd_state pointer from kvm_vcpu_arch")
Signed-off-by: Fuad Tabba <tabba@google.com>
Acked-by: Oliver Upton <oliver.upton@linux.dev>
Link: https://lore.kernel.org/r/20240423150538.2103045-2-tabba@google.com
Signed-off-by: Marc Zyngier <maz@kernel.org>
arch/arm64/kvm/hyp/include/nvhe/pkvm.h
arch/arm64/kvm/hyp/nvhe/pkvm.c
arch/arm64/kvm/hyp/nvhe/setup.c

index 82b3d62538a6111cc3c3d6d65d99d5e613d14fae..20c3f6e13b99f4750fdaf1c9b157c8f6ef62ebba 100644 (file)
@@ -54,6 +54,7 @@ pkvm_hyp_vcpu_to_hyp_vm(struct pkvm_hyp_vcpu *hyp_vcpu)
 }
 
 void pkvm_hyp_vm_table_init(void *tbl);
+void pkvm_host_fpsimd_state_init(void);
 
 int __pkvm_init_vm(struct kvm *host_kvm, unsigned long vm_hva,
                   unsigned long pgd_hva);
index 26dd9a20ad6e6dccd2083e5804e4a063997c958e..492b7fc2c0c7312bf8ef9fa78a1a3fb1018f29d7 100644 (file)
@@ -247,6 +247,17 @@ void pkvm_hyp_vm_table_init(void *tbl)
        vm_table = tbl;
 }
 
+void pkvm_host_fpsimd_state_init(void)
+{
+       unsigned long i;
+
+       for (i = 0; i < hyp_nr_cpus; i++) {
+               struct kvm_host_data *host_data = per_cpu_ptr(&kvm_host_data, i);
+
+               host_data->fpsimd_state = &host_data->host_ctxt.fp_regs;
+       }
+}
+
 /*
  * Return the hyp vm structure corresponding to the handle.
  */
index ae00dfa80801375d76aacf5bcb63642d140f51cb..859f22f754d373a8d74cbd613f3d2e62e009a211 100644 (file)
@@ -300,6 +300,7 @@ void __noreturn __pkvm_init_finalise(void)
                goto out;
 
        pkvm_hyp_vm_table_init(vm_table_base);
+       pkvm_host_fpsimd_state_init();
 out:
        /*
         * We tail-called to here from handle___pkvm_init() and will not return,