media: imx-jpeg: Fix possible null pointer dereference
authorMirela Rabulea <mirela.rabulea@nxp.com>
Mon, 27 Sep 2021 18:56:32 +0000 (20:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:16:14 +0000 (19:16 +0100)
[ Upstream commit 83f5f0633b156c636f5249d3c10f2a9423dd4c96 ]

Found by Coverity scan.

Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com>
Reviewed-by: Laurentiu Palcu <laurentiu.palcu@nxp.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/imx-jpeg/mxc-jpeg.c

index 755138063ee6188b4131ea77011752664d7871de..33e7604271cdfa139a91fb3497ec91074e3ad37a 100644 (file)
@@ -575,6 +575,10 @@ static irqreturn_t mxc_jpeg_dec_irq(int irq, void *priv)
 
        dst_buf = v4l2_m2m_next_dst_buf(ctx->fh.m2m_ctx);
        src_buf = v4l2_m2m_next_src_buf(ctx->fh.m2m_ctx);
+       if (!dst_buf || !src_buf) {
+               dev_err(dev, "No source or destination buffer.\n");
+               goto job_unlock;
+       }
        jpeg_src_buf = vb2_to_mxc_buf(&src_buf->vb2_buf);
 
        if (dec_ret & SLOT_STATUS_ENC_CONFIG_ERR) {