wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize()

If request_partial_firmware_into_buf() fails then "firmware" is not
initialized and the release_firmware(firmware) will crash.

Fixes: deebea35d699 ("wifi: rtw89: early recognize FW feature to decide if chanctx")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/YyMzDtX/3fUBnonC@kili

diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index 04fee40b062a0896c3973df823604a7e7f40b381..5e65f2c410bfd792a4b010815b2f14104f2dcc34 100644 (file)
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -271,7 +271,7 @@ void rtw89_early_fw_feature_recognize(struct device *device,
                                                device, &buf, sizeof(buf), 0);
        if (ret) {
                dev_err(device, "failed to early request firmware: %d\n", ret);
-               goto out;
+               return;
        }
 
        ver_code = buf.mfw_hdr.sig != RTW89_MFW_SIG ?