IB: Remove unneeded memset

In commit af7ddd8a627c ("Merge tag 'dma-mapping-4.21' of
git://git.infradead.org/users/hch/dma-mapping"),
dma_alloc_coherent/dmam_alloc_coherent always zeroed the returned memory.
So the memset after a coherent allocation function is not needed.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_hal.c
index 37ee93824349dc1b1a03fa93505e8c9310914325..95b22a651673a100102ec1cf4a091de1a7716d4e 100644 (file)
--- a/drivers/infiniband/hw/cxgb3/cxio_hal.c
+++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c
@@ -174,7 +174,6 @@ int cxio_create_cq(struct cxio_rdev *rdev_p, struct t3_cq *cq, int kernel)
                return -ENOMEM;
        }
        dma_unmap_addr_set(cq, mapping, cq->dma_addr);
-       memset(cq->queue, 0, size);
        setup.id = cq->cqid;
        setup.base_addr = (u64) (cq->dma_addr);
        setup.size = 1UL << cq->size_log2;
@@ -522,8 +521,6 @@ static int cxio_hal_init_ctrl_qp(struct cxio_rdev *rdev_p)
        dma_unmap_addr_set(&rdev_p->ctrl_qp, mapping,
                           rdev_p->ctrl_qp.dma_addr);
        rdev_p->ctrl_qp.doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr;
-       memset(rdev_p->ctrl_qp.workq, 0,
-              (1 << T3_CTRL_QP_SIZE_LOG2) * sizeof(union t3_wr));
 
        mutex_init(&rdev_p->ctrl_qp.lock);
        init_waitqueue_head(&rdev_p->ctrl_qp.waitq);

diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c
index 3cc4d3331a3ffcdb5c15b11d59d7ce7d6072518f..b1bb61c65f4f684bdc34dc7f18e972f5f0905bc5 100644 (file)
--- a/drivers/infiniband/hw/cxgb4/cq.c
+++ b/drivers/infiniband/hw/cxgb4/cq.c
@@ -102,7 +102,6 @@ static int create_cq(struct c4iw_rdev *rdev, struct t4_cq *cq,
                goto err3;
        }
        dma_unmap_addr_set(cq, mapping, cq->dma_addr);
-       memset(cq->queue, 0, cq->memsize);
 
        if (user && ucontext->is_32b_cqe) {
                cq->qp_errp = &((struct t4_status_page *)

diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index 9523986d62b158cb8ee6f630bbb7c4457cedb5fd..eb9368be28c1df457f948b19ff4ef103c8dac12f 100644 (file)
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -274,7 +274,6 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq,
                         (unsigned long long)virt_to_phys(wq->sq.queue),
                         wq->rq.queue,
                         (unsigned long long)virt_to_phys(wq->rq.queue));
-               memset(wq->rq.queue, 0, wq->rq.memsize);
                dma_unmap_addr_set(&wq->rq, mapping, wq->rq.dma_addr);
        }
 

diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
index 056a6873df7a1c97e0165884cd22ff9e61b9090c..998431c39b8d8dc58a197da06812dd03a11b23aa 100644 (file)
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
@@ -4265,7 +4265,6 @@ static int hns_roce_v1_create_eq(struct hns_roce_dev *hr_dev,
                }
 
                eq->buf_list[i].map = tmp_dma_addr;
-               memset(eq->buf_list[i].buf, 0, HNS_ROCE_BA_SIZE);
        }
        eq->cons_index = 0;
        roce_set_field(tmp, ROCEE_CAEP_AEQC_AEQE_SHIFT_CAEP_AEQC_STATE_M,

diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 7f2da5e10e67483a4995b0fc9bda2c2384f28bd6..107330df6ce89f7876af7452878b268504a64f08 100644 (file)
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -1818,7 +1818,6 @@ static int hns_roce_init_link_table(struct hns_roce_dev *hr_dev,
                        goto err_alloc_buf_failed;
 
                link_tbl->pg_list[i].map = t;
-               memset(link_tbl->pg_list[i].buf, 0, buf_chk_sz);
 
                entry[i].blk_ba0 = (t >> 12) & 0xffffffff;
                roce_set_field(entry[i].blk_ba1_nxt_ptr,
@@ -5467,8 +5466,6 @@ static int hns_roce_mhop_alloc_eq(struct hns_roce_dev *hr_dev,
                eq->cur_eqe_ba = eq->l0_dma;
                eq->nxt_eqe_ba = 0;
 
-               memset(eq->bt_l0, 0, eq->entries * eq->eqe_size);
-
                return 0;
        }
 

diff --git a/drivers/infiniband/hw/mthca/mthca_allocator.c b/drivers/infiniband/hw/mthca/mthca_allocator.c
index aaf10dd5364d44c80b1e9767d0d2a36b8aec0280..aef1d274a14e4bb11418f54239bd5c30e1fefd9b 100644 (file)
--- a/drivers/infiniband/hw/mthca/mthca_allocator.c
+++ b/drivers/infiniband/hw/mthca/mthca_allocator.c
@@ -214,8 +214,6 @@ int mthca_buf_alloc(struct mthca_dev *dev, int size, int max_direct,
 
                dma_unmap_addr_set(&buf->direct, mapping, t);
 
-               memset(buf->direct.buf, 0, size);
-
                while (t & ((1 << shift) - 1)) {
                        --shift;
                        npages *= 2;

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index b2dd4e0a4be27ce8e813eac0ec8aed6170547e91..d82d3ec3649ea0cfa9ea337b0b89ac948f65b11d 100644 (file)
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1351,7 +1351,6 @@ static int ocrdma_mbx_get_ctrl_attribs(struct ocrdma_dev *dev)
        mqe->u.nonemb_req.sge[0].pa_hi = (u32) upper_32_bits(dma.pa);
        mqe->u.nonemb_req.sge[0].len = dma.size;
 
-       memset(dma.va, 0, dma.size);
        ocrdma_init_mch((struct ocrdma_mbx_hdr *)dma.va,
                        OCRDMA_CMD_GET_CTRL_ATTRIBUTES,
                        OCRDMA_SUBSYS_COMMON,
@@ -1690,7 +1689,6 @@ static int ocrdma_mbx_create_ah_tbl(struct ocrdma_dev *dev)
                goto mem_err_ah;
        dev->av_tbl.pa = pa;
        dev->av_tbl.num_ah = max_ah;
-       memset(dev->av_tbl.va, 0, dev->av_tbl.size);
 
        pbes = (struct ocrdma_pbe *)dev->av_tbl.pbl.va;
        for (i = 0; i < dev->av_tbl.size / OCRDMA_MIN_Q_PAGE_SIZE; i++) {
@@ -2903,7 +2901,6 @@ static int ocrdma_mbx_get_dcbx_config(struct ocrdma_dev *dev, u32 ptype,
        mqe_sge->pa_hi = (u32) upper_32_bits(pa);
        mqe_sge->len = cmd.hdr.pyld_len;
 
-       memset(req, 0, sizeof(struct ocrdma_get_dcbx_cfg_req));
        ocrdma_init_mch(&req->hdr, OCRDMA_CMD_GET_DCBX_CONFIG,
                        OCRDMA_SUBSYS_DCBX, cmd.hdr.pyld_len);
        req->param_type = ptype;