NFSD: Add nfsd4_encode_fattr4_layout_blksize()
authorChuck Lever <chuck.lever@oracle.com>
Mon, 18 Sep 2023 14:01:40 +0000 (10:01 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 16 Oct 2023 16:44:25 +0000 (12:44 -0400)
Refactor the encoder for FATTR4_LAYOUT_BLKSIZE into a helper. In a
subsequent patch, this helper will be called from a bitmask loop.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index a6aa49777010b0b2dd13ff1fce45b706263546ac..5d63ad47f5079da63e5a98e512add4768664d33c 100644 (file)
@@ -3312,6 +3312,12 @@ static __be32 nfsd4_encode_fattr4_layout_types(struct xdr_stream *xdr,
        return nfs_ok;
 }
 
+static __be32 nfsd4_encode_fattr4_layout_blksize(struct xdr_stream *xdr,
+                                                const struct nfsd4_fattr_args *args)
+{
+       return nfsd4_encode_uint32_t(xdr, args->stat.blksize);
+}
+
 #endif
 
 /*
@@ -3686,10 +3692,9 @@ nfsd4_encode_fattr(struct xdr_stream *xdr, struct svc_fh *fhp,
        }
 
        if (bmval2 & FATTR4_WORD2_LAYOUT_BLKSIZE) {
-               p = xdr_reserve_space(xdr, 4);
-               if (!p)
-                       goto out_resource;
-               *p++ = cpu_to_be32(args.stat.blksize);
+               status = nfsd4_encode_fattr4_layout_blksize(xdr, &args);
+               if (status != nfs_ok)
+                       goto out;
        }
 #endif /* CONFIG_NFSD_PNFS */
        if (bmval2 & FATTR4_WORD2_SUPPATTR_EXCLCREAT) {