vfio/ccw: Update trace data for not operational event
authorEric Farman <farman@linux.ibm.com>
Thu, 7 Jul 2022 13:57:33 +0000 (15:57 +0200)
committerAlex Williamson <alex.williamson@redhat.com>
Thu, 7 Jul 2022 20:06:12 +0000 (14:06 -0600)
We currently cut a very basic trace whenever the FSM directs
control to the not operational routine.

Convert this to a message, so it's alongside the other configuration
related traces (create, remove, etc.), and record both the event
that brought us here and the current state of the device.
This will provide some better footprints if things go bad.

Suggested-by: Matthew Rosato <mjrosato@linux.ibm.com>
Signed-off-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Link: https://lore.kernel.org/r/20220707135737.720765-8-farman@linux.ibm.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/s390/cio/vfio_ccw_fsm.c

index bbcc5b486749600ec6c26503e90b9872109cf9c6..88e529a2e184820326f19e8135d78f57d5d69d6e 100644 (file)
@@ -160,8 +160,12 @@ static void fsm_notoper(struct vfio_ccw_private *private,
 {
        struct subchannel *sch = private->sch;
 
-       VFIO_CCW_TRACE_EVENT(2, "notoper");
-       VFIO_CCW_TRACE_EVENT(2, dev_name(&sch->dev));
+       VFIO_CCW_MSG_EVENT(2, "sch %x.%x.%04x: notoper event %x state %x\n",
+                          sch->schid.cssid,
+                          sch->schid.ssid,
+                          sch->schid.sch_no,
+                          event,
+                          private->state);
 
        /*
         * TODO: