drm/msm/hdmi: check return value after calling platform_get_resource_byname()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 22 Apr 2022 03:22:27 +0000 (11:22 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:22:52 +0000 (10:22 +0200)
[ Upstream commit a36e506711548df923ceb7ec9f6001375be799a5 ]

It will cause null-ptr-deref if platform_get_resource_byname() returns NULL,
we need check the return value.

Fixes: c6a57a50ad56 ("drm/msm/hdmi: add hdmi hdcp support (V3)")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/482992/
Link: https://lore.kernel.org/r/20220422032227.2991553-1-yangyingliang@huawei.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/msm/hdmi/hdmi.c

index d5a80fa3e6251050b887c3feccce53bf9c0ed6a1..c3d95e7af1e423d4083e82b2a4fe80e0232bad5b 100644 (file)
@@ -144,6 +144,10 @@ static struct hdmi *msm_hdmi_init(struct platform_device *pdev)
        /* HDCP needs physical address of hdmi register */
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
                config->mmio_name);
+       if (!res) {
+               ret = -EINVAL;
+               goto fail;
+       }
        hdmi->mmio_phy_addr = res->start;
 
        hdmi->qfprom_mmio = msm_ioremap(pdev,