cifs: add xid to query server interface call
authorShyam Prasad N <sprasad@microsoft.com>
Mon, 30 Oct 2023 11:00:08 +0000 (11:00 +0000)
committerSteve French <stfrench@microsoft.com>
Tue, 31 Oct 2023 17:38:26 +0000 (12:38 -0500)
We were passing 0 as the xid for the call to query
server interfaces. This is not great for debugging.
This change adds a real xid.

Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Reviewed-by: Bharath SM <bharathsm@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/connect.c

index 7b923e36501b0bb09f7a1339004ab23f335510e0..15a1c86482ed857afba66e060fc92239c4f0cfba 100644 (file)
@@ -119,6 +119,7 @@ static int reconn_set_ipaddr_from_hostname(struct TCP_Server_Info *server)
 static void smb2_query_server_interfaces(struct work_struct *work)
 {
        int rc;
+       int xid;
        struct cifs_tcon *tcon = container_of(work,
                                        struct cifs_tcon,
                                        query_interfaces.work);
@@ -126,7 +127,10 @@ static void smb2_query_server_interfaces(struct work_struct *work)
        /*
         * query server network interfaces, in case they change
         */
-       rc = SMB3_request_interfaces(0, tcon, false);
+       xid = get_xid();
+       rc = SMB3_request_interfaces(xid, tcon, false);
+       free_xid(xid);
+
        if (rc) {
                cifs_dbg(FYI, "%s: failed to query server interfaces: %d\n",
                                __func__, rc);