media: imx-pxp: Use non-threaded IRQ
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Fri, 13 Jan 2023 09:54:21 +0000 (10:54 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Wed, 8 Feb 2023 08:21:14 +0000 (09:21 +0100)
There's no need to use threaded IRQs with the PXP, as the interrupt
handler doesn't need to sleep and doesn't perform any time-consuming
operation. Switch to regular IRQ handler.

This fixes lockups of the PXP noticed on i.MX7, where the PXP would stop
generating interrupts after a variable number of frames (from a few
dozens to a few hundreds). The root cause is however unknown.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/nxp/imx-pxp.c

index cad1a201e1aafb979cda17a5d6d1add26b9b6740..f44cf16be94241968a0642e3e5a74cafc32225e9 100644 (file)
@@ -1798,8 +1798,8 @@ static int pxp_probe(struct platform_device *pdev)
 
        spin_lock_init(&dev->irqlock);
 
-       ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, pxp_irq_handler,
-                       IRQF_ONESHOT, dev_name(&pdev->dev), dev);
+       ret = devm_request_irq(&pdev->dev, irq, pxp_irq_handler, 0,
+                              dev_name(&pdev->dev), dev);
        if (ret < 0) {
                dev_err(&pdev->dev, "Failed to request irq: %d\n", ret);
                return ret;